WestMidlands| SDC-Nov-2025 | Sara Tahir| Sprint 1| Profile/login #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaraTahir28
added
the
Needs Review
illicitonion
reviewed
Feb 4, 2026
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Good fix!
The comments you've left in-line are a bit noisy - in real life we'd probably just include them in the PR description (and maybe the commit message) - comments about how things work can be useful, but comments explaining how you fixed a bug generally don't live in the code long-term
illicitonion
added
Complete
Author
|
Thankyou, I will keep this in mind from now on. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have fixed the bug of not being able to login from the profile view of the App.
I added the correct data- form attribute and submit event listener.
I also did manual browser testing that shows that after the chnage made, user can now login successfully from the profile view.
Questions
I have no Questions.